Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace --skip-aggressive-merging with all property merges implemented. #290

Closed
GoalSmashers opened this issue Jun 8, 2014 · 1 comment
Closed

Replace --skip-aggressive-merging with all property merges implemented. #290

GoalSmashers opened this issue Jun 8, 2014 · 1 comment
Labels
enhancement
Milestone
4.0

Comments

@GoalSmashers
Copy link
Contributor

No description provided.

@GoalSmashers GoalSmashers added this to the 2.4 milestone Jun 8, 2014
GoalSmashers pushed a commit that referenced this issue Jun 8, 2014
Fixes #210 - adds temporary workaround for aggressive property merging.
7804a0d 
Using `--skip-aggressive-merging` / `noAggressiveMerging` switch skips property merging based on order.
Will be fixed in #290.
GoalSmashers pushed a commit that referenced this issue Jun 8, 2014
Fixes #210 - adds temporary workaround for aggressive property merging.
fa7d69e 
Using `--skip-aggressive-merging` / `noAggressiveMerging` switch skips property merging based on order.
Will be fixed in #290.
@GoalSmashers GoalSmashers mentioned this issue Jun 8, 2014
Closed
@GoalSmashers GoalSmashers mentioned this issue Jul 14, 2014
Closed
@GoalSmashers GoalSmashers mentioned this issue Aug 2, 2014
Closed
@jakubpawlowicz jakubpawlowicz mentioned this issue Aug 30, 2014
Closed
@jakubpawlowicz jakubpawlowicz mentioned this issue Sep 22, 2014
Closed
@jakubpawlowicz jakubpawlowicz modified the milestones: future, 3.1 Dec 18, 2014
@jakubpawlowicz jakubpawlowicz mentioned this issue Apr 18, 2015
Closed
@jakubpawlowicz jakubpawlowicz changed the title Replace 2.2 --skip-aggressive-merging with all properties merges implemented. Replace 2.2 --skip-aggressive-merging with all property merges implemented. Apr 18, 2015
@jakubpawlowicz jakubpawlowicz mentioned this issue Apr 22, 2015
Closed
jakubpawlowicz added a commit that referenced this issue May 4, 2015
@jakubpawlowicz
Fixes #375 - unit compatibility switches.
6698f48 
Adds compatibility switches for `ch`, `vh`, `vm`, `vmax`, `vmin`,
and `vw` units.

Note we need #290 to fully support all use cases. Currently it'll be
just for implemented shorthands.
@jakubpawlowicz jakubpawlowicz mentioned this issue Aug 6, 2015
Closed
@jakubpawlowicz jakubpawlowicz mentioned this issue Aug 19, 2015
Closed
@jakubpawlowicz jakubpawlowicz changed the title Replace 2.2 --skip-aggressive-merging with all property merges implemented. Replace --skip-aggressive-merging with all property merges implemented. Aug 19, 2015
This was referenced Sep 16, 2015
Closed
Closed
@lunaleaps lunaleaps mentioned this issue Nov 23, 2015
Closed
@jakubpawlowicz jakubpawlowicz mentioned this issue Nov 23, 2015
Closed
@hostep hostep mentioned this issue Mar 19, 2016
Closed
@jakubpawlowicz jakubpawlowicz mentioned this issue Mar 31, 2016
Closed
jakubpawlowicz added a commit that referenced this issue Jan 1, 2017
@jakubpawlowicz
See #290 - allows height overriding.
78f4aaf 
Why:

* Another step to move away from aggressive merging.
jakubpawlowicz added a commit that referenced this issue Jan 1, 2017
@jakubpawlowicz
See #290 - allows font-weight overriding.
28bc3e8 
Why:

* Another step to move away from aggressive merging.
@jakubpawlowicz jakubpawlowicz modified the milestones: future, ~future~ Jan 4, 2017
@jakubpawlowicz jakubpawlowicz modified the milestones: ~future~, 4.0 Jan 4, 2017
This was referenced Jan 4, 2017
Closed
Closed
jakubpawlowicz added a commit that referenced this issue Jan 18, 2017
@jakubpawlowicz
See #290 - disables animation shorthand overriding.
2fe18ee 
Why:

* It's a shorthand property, so not straightforward to implement
  in shorthand/override compacting;
* pending in #860.
jakubpawlowicz added a commit that referenced this issue Jan 18, 2017
@jakubpawlowicz
See #290 - disables transition shorthand overriding.
50a0278 
Why:

* It's a shorthand property, so not straightforward to implement
  in shorthand/override compacting;
* pending in #861.
jakubpawlowicz added a commit that referenced this issue Jan 18, 2017
@jakubpawlowicz
See #290 - disables font shorthand overriding.
e1d88d3 
Why:

* It's a shorthand property, so not straightforward to implement
  in shorthand/override compacting;
* pending in #254.
jakubpawlowicz added a commit that referenced this issue Jan 18, 2017
@jakubpawlowicz
See #290 - reworks border overriding.
04b4958 
Why:

* Border is a complex case where both `border` and all its
  components: `border-color`, `border-style`, and `border-width`
  are components. Also `border-(bottom|left|right|top)` are
  shorthands too.
* this commit restores aggressive merging shorthand overriding right
  inside shorthand compacting code.
jakubpawlowicz added a commit that referenced this issue Jan 18, 2017
@jakubpawlowicz
See #290 - removes aggressive merging.
11efd42 
Why:

* Aggressive merging was replaced by override merging;
* it supports much more properties now so aggressive merging won't
  be missed;
* it also overrides based on understandability not merely a
  position in output file.

Side notes:

* This is a safe change as if a property is not configured to
  be overridable it won't be;
* overhauls `canOverride` functionality to prevent features like
  vendor prefixes or variables from overriding widely supported
  values;
* overhauls validating values by allowing known values, which
  strictly doesn't make it a full validator but rather a way
  of telling if a value *may* be valid.
jakubpawlowicz added a commit that referenced this issue Jan 18, 2017
@jakubpawlowicz
See #290 - adds removing IE filters.
a6ec1d2 
Why:

* Internet Explorer `filter` / `-ms-filter` are unsupported since
  IE 10, which is also clean-css new default compatibility;
* can be restored by using `ie7`, `ie8`, or `ie9` compatibility
  modes.
jakubpawlowicz added a commit that referenced this issue Jan 18, 2017
@jakubpawlowicz
fixup! See #290 - removes aggressive merging.
5be24e6
jakubpawlowicz added a commit that referenced this issue Jan 18, 2017
@jakubpawlowicz
Moves 'compacting' code to 'properties' folder-space.
6ff65e5 
Why:

* All those optimizations are dealing with properties so the new
  name better reflects its role;

Also:

* renames `overrideCompactor` to `overrideProperties`;
* renames `compactorOptimize` to `optimizeProperties`.
* cleans up property optimizing code calling from level 2 optimizations
  due to removal of aggressive merging, see #290.
jakubpawlowicz added a commit that referenced this issue Jan 19, 2017
@jakubpawlowicz
See #290 - removes aggressive merging.
41a4fb4 
Why:

* Aggressive merging was replaced by override merging;
* it supports much more properties now so aggressive merging won't
  be missed;
* it also overrides based on understandability not merely a
  position in output file.

Side notes:

* This is a safe change as if a property is not configured to
  be overridable it won't be;
* overhauls `canOverride` functionality to prevent features like
  vendor prefixes or variables from overriding widely supported
  values;
* overhauls validating values by allowing known values, which
  strictly doesn't make it a full validator but rather a way
  of telling if a value *may* be valid.
jakubpawlowicz added a commit that referenced this issue Jan 19, 2017
@jakubpawlowicz
See #290 - adds removing IE filters.
0464d91 
Why:

* Internet Explorer `filter` / `-ms-filter` are unsupported since
  IE 10, which is also clean-css new default compatibility;
* can be restored by using `ie7`, `ie8`, or `ie9` compatibility
  modes.
jakubpawlowicz added a commit that referenced this issue Jan 19, 2017
@jakubpawlowicz
Moves 'compacting' code to 'properties' folder-space.
0c2ceac 
Why:

* All those optimizations are dealing with properties so the new
  name better reflects its role;

Also:

* renames `overrideCompactor` to `overrideProperties`;
* renames `compactorOptimize` to `optimizeProperties`.
* cleans up property optimizing code calling from level 2 optimizations
  due to removal of aggressive merging, see #290.
@jakubpawlowicz
Copy link
Collaborator

Phew, aggressive merging is gone. #254, #860, and #861 will add support for the missing shorthands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
2 participants
@jakubpawlowicz @GoalSmashers