Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate floats in same selector aren't always removed. #540

Closed
hostep opened this issue Apr 21, 2015 · 2 comments
Closed

Duplicate floats in same selector aren't always removed. #540

hostep opened this issue Apr 21, 2015 · 2 comments

Comments

@hostep
Copy link

hostep commented Apr 21, 2015

Using cleancss 3.2.2

This is correct:

➜ echo 'p {float: right; float: right;}' | ./cleancss
p{float:right}

This is not what I expected:

➜ echo 'p {float: left; float: right;}' | ./cleancss
p{float:left;float:right}

It should output:

p{float:right}

This is also not what I expected:

➜ echo 'p {float: right; float: right !important;}' | ./cleancss
p{float:right;float:right!important}

It should output:

p{float:right!important}

The last case worked in 3.1.9 as expected (I didn't test it explicitly, but I can see it from the diffs of a very large file)

@jakubpawlowicz
Copy link
Collaborator

It's still correct though. Let me see if we can restore the old functionality, otherwise it will have to wait for #290.

@jakubpawlowicz
Copy link
Collaborator

It waits for #290 to be implemented in 3.5. Closing as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants