Fixes #957 - 0% minification of width property.

Why: * Apparently `width` and `max-width` `0%` value cannot be turned into `0`, see: https://codepen.io/judowalker/pen/xrMxWj
clean-css · Jul 14, 2017 · 5120ea4 · 5120ea4
1 parent 8c63ce0
commit 5120ea4
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 3 deletions.
diff --git a/History.md b/History.md
@@ -1,3 +1,8 @@
+[4.1.7 / 2017-xx-xx](https://github.com/jakubpawlowicz/clean-css/compare/v4.1.6...4.1)
+==================
+
+* Fixed issue [#957](https://github.com/jakubpawlowicz/clean-css/issues/957) - `0%` minification of `width` property.
+
 [4.1.6 / 2017-07-08](https://github.com/jakubpawlowicz/clean-css/compare/v4.1.5...v4.1.6)
 ==================
 

diff --git a/lib/optimizer/level-1/optimize.js b/lib/optimizer/level-1/optimize.js
@@ -269,7 +269,7 @@ function optimizeUnits(name, value, unitsRegexp) {
     return value;
   }
 
-  if (value.indexOf('%') > 0 && (name == 'height' || name == 'max-height')) {
+  if (value.indexOf('%') > 0 && (name == 'height' || name == 'max-height' || name == 'width' || name == 'max-width')) {
     return value;
   }
 

diff --git a/test/optimizer/level-1/optimize-test.js b/test/optimizer/level-1/optimize-test.js
@@ -894,8 +894,8 @@ vows.describe('level 1 optimizations')
         'a{margin:0}'
       ],
       '-0% to 0': [
-        'a{width:-0%}',
-        'a{width:0}'
+        'a{min-width:-0%}',
+        'a{min-width:0}'
       ],
       'missing': [
         'a{opacity:1.}',
@@ -968,6 +968,18 @@ vows.describe('level 1 optimizations')
       'max-height': [
         'a{max-height:0%}',
         'a{max-height:0%}'
+      ],
+      'width': [
+        'a{width:0%}',
+        'a{width:0%}'
+      ],
+      'min-width': [
+        'a{min-width:0%}',
+        'a{min-width:0}'
+      ],
+      'max-width': [
+        'a{max-width:0%}',
+        'a{max-width:0%}'
       ]
     }, { level: 1 })
   )