add py as requirement for test #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workaround for issue https://gitlab.com/uweschmitt/pytest-regtest/-/issues/19 Signed-off-by: Gerardo Roa Dabike <gerardo.roa@gmail.com>
ns-rse
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
Thanks for adding this work around @groadabike 👍
If and when the issue with pytest-regtest gets resolved I'll update things.
setup.cfg
Outdated
| @@ -65,6 +65,7 @@ tests = | |||
| pytest-mpl | |||
| pytest-regtest | |||
| yamllint | |||
| py | |||
There was a problem hiding this comment.
Overly pedantic but the list is alphabetical I think to aid reading (well it helps me at least!), so I'd have slotted this in between pre-commit and pytest.
workaround for issue https://gitlab.com/uweschmitt/pytest-regtest/-/issues/19 Signed-off-by: Gerardo Roa Dabike <gerardo.roa@gmail.com>
…t' into 95-add-py-as-requirement-for-test
|
As requested, I changed the order of the requirements. Little by little, getting there with the best practices |
Codecov Report
@@ Coverage Diff @@
## main #96 +/- ##
==========================================
- Coverage 84.30% 83.85% -0.45%
==========================================
Files 30 30
Lines 3370 3370
==========================================
- Hits 2841 2826 -15
- Misses 529 544 +15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workaround for issue https://gitlab.com/uweschmitt/pytest-regtest/-/issues/19
Signed-off-by: Gerardo Roa Dabike gerardo.roa@gmail.com