Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring HAAQI to save precomputations #364

Open
wants to merge 60 commits into
base: main
Choose a base branch
from

Conversation

groadabike
Copy link
Contributor

@groadabike groadabike commented Feb 20, 2024

closes #363

This is the first draft of the refactoring of HAAQI to precompute and reuse some parts of the code.
This logic can the be applied to HASPI and HASQI

Need to run a more extensive sanity test to ensure the consistency of the output compared with the old implementation

TODO:

  • Run the metric several times to measure consistency with old implementation
  • Create unit and regression tests

@groadabike groadabike linked an issue Feb 20, 2024 that may be closed by this pull request
@groadabike groadabike self-assigned this Feb 20, 2024
@groadabike groadabike added enhancement New feature or request refactor Refactor of existing code Cadenza labels Feb 20, 2024
@groadabike groadabike added this to the CAD2 - pyclarity 0.7.0 milestone Feb 20, 2024
@groadabike
Copy link
Contributor Author

@jonbarker68, this is a draft of this refactoring.
if you have a minute, can you take a look to see if makes sense to you?

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: Patch coverage is 99.11243% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 93.80%. Comparing base (d78922f) to head (6c9b9cb).
Report is 1 commits behind head on main.

❗ Current head 6c9b9cb differs from pull request most recent head 099ce34. Consider uploading reports for the commit 099ce34 to get more accurate results

Files Patch % Lines
clarity/evaluator/ha/pyhaaqi.py 98.14% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #364      +/-   ##
==========================================
+ Coverage   92.88%   93.80%   +0.91%     
==========================================
  Files          43       46       +3     
  Lines        3921     4597     +676     
==========================================
+ Hits         3642     4312     +670     
- Misses        279      285       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@groadabike groadabike marked this pull request as ready for review February 23, 2024 12:32
@groadabike groadabike mentioned this pull request Feb 23, 2024
@groadabike
Copy link
Contributor Author

groadabike commented Feb 23, 2024

The output of this refactoring is not exactly the same as previous implementation due to the different order in when random noises are generated.

groadabike and others added 24 commits February 27, 2024 10:37
…' into 363-add-precomputations-to-haaqi

# Conflicts:
#	clarity/evaluator/ha/pyhaaqi.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cadenza enhancement New feature or request refactor Refactor of existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add precomputations to HAAQI
1 participant