feat(complete): support command alias completions #5412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epage
reviewed
Mar 21, 2024
clap_complete/src/generator/utils.rs
Outdated
| @@ -49,6 +49,10 @@ pub fn subcommands(p: &Command) -> Vec<(String, String)> { | |||
| ); | |||
|
|
|||
| subcmds.push((sc.get_name().to_string(), sc_bin_name.to_string())); | |||
|
|
|||
| for a in sc.get_all_aliases() { | |||
There was a problem hiding this comment.
As we are generally only doing visible aliases, can you switch this to get_visible_aliases?
There was a problem hiding this comment.
sure! on it!
i wasn't sure here because my thinking was that if someone was using an alias, visible or not, they should be getting auto completion still. would using get_visible_aliases break this behaviour? is it intended? (this is a discussion that can be moved to the issue(s) if necessary
nasso
force-pushed
the
push-vpkvrkyzppwr
branch
from
16ae64a
to
24ac929
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4265
first time contributor here! this is probably very naive!
this might be a good temporary "hack" while we wait for #3951 and #3166. if that's a problem maybe a feature flag can be introduced, because tools with a lot of very common aliases (like
jj) barely get any completion support right now