Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(parser): Reduce lookups for conflicts #4572

Merged
merged 3 commits into from Dec 22, 2022
Merged

perf(parser): Reduce lookups for conflicts #4572

merged 3 commits into from Dec 22, 2022

Commits on Dec 22, 2022

  1. perf(parser): Reduce lookups for conflicts 

    We already need to lookup every present-arg for conflicts, so we might
as well cache it ahead of time.  This let's us move some operations to
be immutable so we can more easily cache other lookups.

For me, this gave a 70% speed improvement for clap-rs#4516 with mixed results
on normal benchmarks
    @epage
    epage committed Dec 22, 2022
    Copy the full SHA
    4a34b9d View commit details
    Browse the repository at this point in the history

  2. perf(parser): Reduce duplicate lookups 

    Didn't actually see much of a gain because this isn't in a hot loop but
thought I'd keep it.
    @epage
    epage committed Dec 22, 2022
    Copy the full SHA
    dd8435d View commit details
    Browse the repository at this point in the history

  3. style: Update for latest clippy

    @epage
    epage committed Dec 22, 2022
    Copy the full SHA
    dde22e7 View commit details
    Browse the repository at this point in the history