Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve ValueParser experience #4509

Merged
merged 5 commits into from Nov 24, 2022
Merged

feat: Improve ValueParser experience #4509

merged 5 commits into from Nov 24, 2022

Commits on Nov 24, 2022

  1. fix: Always expose ColorChoice

    @epage
    epage committed Nov 24, 2022
    Copy the full SHA
    ed683ef View commit details
    Browse the repository at this point in the history

  2. feat: Add Display/FromStr to ColorChoice 

    This matches up with `clap_complete::Shell`.  This makes it a bit more flexible.
    @epage
    epage committed Nov 24, 2022
    Copy the full SHA
    8d92f3e View commit details
    Browse the repository at this point in the history

  3. docs: Clarify ColorChoice impls ValueEnum

    @epage
    epage committed Nov 24, 2022
    Copy the full SHA
    19981a2 View commit details
    Browse the repository at this point in the history

  4. docs: Clarify PossibleValue is likely not needed 

    Fixes clap-rs#4504
    @epage
    epage committed Nov 24, 2022
    Copy the full SHA
    3bccfce View commit details
    Browse the repository at this point in the history

  5. feat: Create ValueParser from Vec<PossibleValue> 

    This dynamically generated list of possible values.  Inspired by clap-rs#4504
    @epage
    epage committed Nov 24, 2022
    Copy the full SHA
    94aca92 View commit details
    Browse the repository at this point in the history