Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(help): Update auto-next-line to use new padding #4463

Merged
merged 2 commits into from Nov 7, 2022
Merged

fix(help): Update auto-next-line to use new padding #4463

merged 2 commits into from Nov 7, 2022

Commits on Nov 7, 2022

  1. refactor(help): Remove dead code 

    `longest` is always the same or longer than the `sc_str.display_width`
    @epage
    epage committed Nov 7, 2022
    Copy the full SHA
    539577d View commit details
    Browse the repository at this point in the history

  2. fix(help): Update auto-next-line to use new padding 

    In clap v4, we changed the padding from 4 to 2 but we didn't update our
calculation for when to switch to next-line-help as it was a magic
number (we tried to catch all of these).

When updating the tests, we also missed that a test was being wrapped
too narrowly

This was found while discussing clap-rs#3300
    @epage
    epage committed Nov 7, 2022
    Copy the full SHA
    dfe9e73 View commit details
    Browse the repository at this point in the history