Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): Only add ArgGroup to ArgMatches for command-line #4375

Merged
merged 7 commits into from Oct 12, 2022

Commits on Oct 12, 2022

  1. Copy the full SHA
    43c1fa3 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    84828e8 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    8cf6d11 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    0f30ac7 View commit details
    Browse the repository at this point in the history
  5. refactor(parser): Centralize group handling

    Since groups are only associated with the occurrence, we can move the
    assigning of it to the occurrence start.
    
    This will help centralize other checks
    epage committed Oct 12, 2022
    Copy the full SHA
    e704adb View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    e98fc7f View commit details
    Browse the repository at this point in the history
  7. fix(parser): Only add ArgGroup to ArgMatches for command-line

    This will fix `clap_derive`s behavior for optional-flattened groups as
    it will properly detect when the group is present (clap-rs#3566).
    
    While I consider this a bug and not part of compatibility guarentees, I
    still want to keep in mind user impact which could still prevent this.
    Defaults will make the group always-present which has little value and
    if anything is relying on this, it is probably an application bug.
    epage committed Oct 12, 2022
    Copy the full SHA
    d0dcaac View commit details
    Browse the repository at this point in the history