Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(derive): Support Option when flattening #4350

Merged
merged 5 commits into from Oct 5, 2022
Merged

feat(derive): Support Option when flattening #4350

merged 5 commits into from Oct 5, 2022

Commits on Oct 5, 2022

  1. fix(derive): Better flatten type errors

    @epage
    epage committed Oct 5, 2022
    Copy the full SHA
    4f17f99 View commit details
    Browse the repository at this point in the history

  2. fix(derive): Better subcommand type errors for Vec

    @epage
    epage committed Oct 5, 2022
    Copy the full SHA
    f121a8b View commit details
    Browse the repository at this point in the history

  3. refactor(derive): Make flatten's update prepped for Option

    @epage
    epage committed Oct 5, 2022
    Copy the full SHA
    33db640 View commit details
    Browse the repository at this point in the history

  4. feat(derive): Support 'Option' when flattening

    @epage
    epage committed Oct 5, 2022
    Copy the full SHA
    06d2049 View commit details
    Browse the repository at this point in the history

  5. fix(derive): Make mismatched behavior more obvious 

    If the inner type never implemented `group_id()`, then it won't work and
people will be confused.  This at least gives people an idea of whats
going wrong.

This is most likely to be a problem until clap-rs#3165 is fully implemented but
hand-implementations can still run into this.  Probably should have made
the groups another trait to catch this in type system but too late.
    @epage
    epage committed Oct 5, 2022
    Copy the full SHA
    78676f5 View commit details
    Browse the repository at this point in the history