Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport Bugfix/3861 to V3: Mangen not showing possible values #4146

Merged
merged 4 commits into from Aug 31, 2022

Commits on Aug 27, 2022

  1. fix: Show possible values in generated man file

    This adds feature parity for mangen with the standard help output. Users
    will now see the list of possible values for value arguments.
    
    One change that was made to make this possible was adding the method
    `get_possible_values` to the public API for an arg. I tried to think of
    a way to get around this, but because this is the interface that the
    help generation uses, and it is part of the crate public interface
    I thing adding it as a part of the public API might be for the best.
    
    cherry-pick to backport this fix to v3
    
    fixes: clap-rs#3861
    Calder-Ty committed Aug 27, 2022
    Copy the full SHA
    17960a4 View commit details
    Browse the repository at this point in the history
  2. fix: Take in account possible values being hidden

    This makes sure we take into account the setting that possible args
    is hidden
    
    backporting to v3-master
    Calder-Ty committed Aug 27, 2022
    Copy the full SHA
    3d085b8 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2022

  1. Copy the full SHA
    9b4c276 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2022

  1. fix: Add possible vals to man for positional args

    Noticed that possible values would not show up for Positional arguments
    as well. Decided to add the changes for those as well.
    Calder-Ty committed Aug 31, 2022
    Copy the full SHA
    f7af765 View commit details
    Browse the repository at this point in the history