fix(derive): Add "id" attribute #4049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielparks
commented
Aug 9, 2022
|
I think the lint check failure is unrelated to my changes. The commit subject is slightly longer than 50 characters, though. I can fix that if you like. |
2 tasks
The lint failure is
I need to go back and do some fixes to committed since its still not all working with the git security fix sigh |
|
Note: it also says to not fuss too much over the commit messages. Its preferred but not required to have them be clean but there isn't a good way to do that with github actions |
Previously the Arg id was set with the "name" attribute. This allows use of an "id" attribute to match the underlying struct. A side effect of this is that the "id" attribute may also be used on Commands. This isn't desired, but given the current architecture of the attribute parser, it's hard to avoid. Fixes: #3785
|
Thanks. It was easy to fix, so I went ahead. |
danielparks
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the Arg id was set with the "name" attribute. This allows use of an "id" attribute to match the underlying struct.
A side effect of this is that the "id" attribute may also be used on Commands. This isn't desired, but given the current architecture of the attribute parser, it's hard to avoid.
Fixes: #3785