Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(parser): Include required argument in message #4006

Merged
merged 2 commits into from Jul 30, 2022
Merged

fix(parser): Include required argument in message #4006

merged 2 commits into from Jul 30, 2022

Commits on Jul 30, 2022

  1. refactor(usage): Clarify required gathering

    @epage
    epage committed Jul 30, 2022
    Copy the full SHA
    ef1424b View commit details
    Browse the repository at this point in the history

  2. fix(parser): Include required argument in message 

    When suggesting required arguments, we wanted to avoid an argument
showing up in both a group and by itself but we didn't correctly
calculate that, causing no required arguments to show up at times.

Now, we all use the same pool of information for doing the calculations.

This was the type of cleanup that I expected it to drop our binary size
but this added 1k to our .text.  Strange.

Fixes clap-rs#4004
    @epage
    epage committed Jul 30, 2022
    Copy the full SHA
    4c43b21 View commit details
    Browse the repository at this point in the history