-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(clap_derive): Add default_values_t
and default_values_os_t
for Vec field types
#3933
feat(clap_derive): Add default_values_t
and default_values_os_t
for Vec field types
#3933
Conversation
hm as I coded this up, I realized I could apply this for all this would be out of scope of #3932, but I'll push another commit with this change as I feel might as well handle it in the same PR? can always reset back to the single commit and submit another PR otherwise :) |
536df7d
to
8cb18d8
Compare
8cb18d8
to
daccb6d
Compare
default_values_t
and default_values_os_t
for Vec field types
daccb6d
to
373905c
Compare
@epage just pushed the changes to address all of your comments (aside from the swapping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the ui tests are passing, I'll merge this.
master
is now for clap v4. Once this is merged, if you want you can then cherry-pick this back to v3-master
branch and submit a new PR.
c967596
to
62c73ad
Compare
62c73ad
to
04e0ed7
Compare
that was a bit annoying, my local |
Implements #3932