Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(parser): Ensure globals override env vars #3879

Merged
merged 2 commits into from Jun 28, 2022
Merged

fix(parser): Ensure globals override env vars #3879

merged 2 commits into from Jun 28, 2022

Commits on Jun 28, 2022

  1. test(parser): Verify global/default interaction

    @epage
    epage committed Jun 28, 2022
    Copy the full SHA
    f082eb6 View commit details
    Browse the repository at this point in the history

  2. fix(parser): Ensure globals override env vars 

    This fixes a bug introduced in 4a694f3
when we were trying to move away from presence checks via occurrences.
I switched it to the common type of presence check but really what we
want is a highest-precedence check.

Fixes clap-rs#3872
    @epage
    epage committed Jun 28, 2022
    Copy the full SHA
    72d206e View commit details
    Browse the repository at this point in the history