Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Deprecate features redundant with Actions #3797

Merged
merged 17 commits into from Jun 8, 2022
Merged

Commits on Jun 6, 2022

  1. Copy the full SHA
    4a694f3 View commit details
    Browse the repository at this point in the history
  2. fix(parser): Deprecate StoreValue / IncOccurrences Actions

    Dropping these will help simplify a lot, including removing of
    occurrences.
    
    These come at the cost of the derive not yet supporting types that impl
    `From`.
    epage committed Jun 6, 2022
    Copy the full SHA
    1879826 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    0ba6366 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    a979cf9 View commit details
    Browse the repository at this point in the history
  5. fix(parser): Deprecate args_override_self

    This shouldn't be needed anymore now that this is effectively the new
    behavior for the non-deprecated actions.
    
    This was briefly talked about in
    clap-rs#2627 but I wasn't familiar
    enough with the implementation to know how safe it is.  Now, maintainrs
    and users can be more confident because they are explicitly opting into
    it.
    
    See also clap-rs#3795
    epage committed Jun 6, 2022
    Copy the full SHA
    1428785 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2022

  1. test: Improve failure output

    epage committed Jun 7, 2022
    Copy the full SHA
    f0cc8b8 View commit details
    Browse the repository at this point in the history
  2. fix(parser): Deprecate occurrences_of

    This mostly exist for
    - Knowing of the value came from the command-line but we now have
      `ArgMatches::source`
    - Counting the number of flags but we now have `ArgAction::Count`
    epage committed Jun 7, 2022
    Copy the full SHA
    86a162d View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    d88ca13 View commit details
    Browse the repository at this point in the history
  4. fix(parser): Force multiple occurrences with new Actions

    This is needed for deprecate `multiple_occurrences`
    epage committed Jun 7, 2022
    Copy the full SHA
    7980c5c View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    efc1520 View commit details
    Browse the repository at this point in the history
  6. fix(derive): Transition off of multiple_occurrences

    For programs opting into the clap v4 behavior (with `action` or
    `value_parser` attributes), we'll no longer generate a
    `multiple_occurrences(true)` call in preparation for deprecating
    `multiple_occurrences`.  See clap-rs#3772.
    epage committed Jun 7, 2022
    Copy the full SHA
    19d8ca8 View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    4a9c4de View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    55a705c View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2022

  1. Copy the full SHA
    1abc945 View commit details
    Browse the repository at this point in the history
  2. style: Make clippy happy

    epage committed Jun 8, 2022
    Copy the full SHA
    b78a0e6 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    14a62e1 View commit details
    Browse the repository at this point in the history
  4. test(derive): Update snapshots

    epage committed Jun 8, 2022
    Copy the full SHA
    11d9314 View commit details
    Browse the repository at this point in the history