Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(validator): Ignore defaults for requireds #3793

Merged
merged 2 commits into from Jun 6, 2022
Merged

fix(validator): Ignore defaults for requireds #3793

merged 2 commits into from Jun 6, 2022

Commits on Jun 6, 2022

  1. refactor(parser): Remove dead code

    @epage
    epage committed Jun 6, 2022
    Copy the full SHA
    ac64391 View commit details
    Browse the repository at this point in the history

  2. fix(validator): Ignore defaults for requireds 

    This is a follow up to clap-rs#3420.  Its easy to overlook this because it is only
useful for the conditionals (we actually prevent applying unconditional
defaults to unconditional requireds).  This became apparent with the
increased use of defaults with `SetTrue`.

As always, there is the question of when is a bug fix a breaking change.
I'm going to consider this safe since we prevent some instances of this
from even happening and we already did clap-rs#3420 and this is in line with
those.
    @epage
    epage committed Jun 6, 2022
    Copy the full SHA
    0f1de73 View commit details
    Browse the repository at this point in the history