Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): Provide default value for Actions #3786

Merged
merged 1 commit into from Jun 3, 2022
Merged

Commits on Jun 3, 2022

  1. fix(parser): Provide default value for Actions

    Actions were inspired by Python and Python does not implicitly default
    any field when an action is given.  From a Builder API perspective, this
    seemed fine because we tend to focus the Builder API on giving the user
    all information so they can make their own decisions.  When working on
    the Derive API, this became a problem because users were going to have
    to migrate from an implied default to an explicit default when a common
    default is good enough most of the time.  This shouldn't interfere with
    Builder users getting more details when needed.
    
    This also highlighted two problems
    - We set the index for defaults
    - We don't debug_assert when applying conditional requirements with a
      default present
    epage committed Jun 3, 2022
    Copy the full SHA
    e4b443d View commit details
    Browse the repository at this point in the history