Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(parser): Simplify the common getter API #3751

Merged
merged 4 commits into from May 25, 2022
Merged

fix(parser): Simplify the common getter API #3751

merged 4 commits into from May 25, 2022

Commits on May 25, 2022

  1. fix(parser): Simplify the common getter API 

    Clap has focused on reporting development errors through assertions
rather than mixing user errors with development errors.  Sometimes,
developers need to handle things more flexibly so included in clap-rs#3732 was
the reporting of value accessor failures as internal errors with a
distinct type.  I've been going back and forth on whether the extra
error pessimises the usability in the common case vs dealing with the
proliferation of different function combinations.  In working on
deprecating the `value_of` functions, I decided that it was going to be
worth duplicating so long as we can keep the documentation focused.
    @epage
    epage committed May 25, 2022
    Configuration menu
    Copy the full SHA
    eda0ca5 View commit details
    Browse the repository at this point in the history

  2. docs(parser): Group args / subcommand funcs separately

    @epage
    epage committed May 25, 2022
    Configuration menu
    Copy the full SHA
    21be77c View commit details
    Browse the repository at this point in the history

  3. docs(parser): Fix typos

    @epage
    epage committed May 25, 2022
    Configuration menu
    Copy the full SHA
    18793d9 View commit details
    Browse the repository at this point in the history

  4. docs(parser): Fix links

    @epage
    epage committed May 25, 2022
    Configuration menu
    Copy the full SHA
    bac68e5 View commit details
    Browse the repository at this point in the history