Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(derive): Allow users to opt-in to ValueParser #3742

Merged
merged 13 commits into from May 23, 2022
Merged

feat(derive): Allow users to opt-in to ValueParser #3742

merged 13 commits into from May 23, 2022

Commits on May 18, 2022

  1. feat(derive): Allow destructively constructing from ArgMatches

    @epage
    epage committed May 18, 2022
    Copy the full SHA
    1446be8 View commit details
    Browse the repository at this point in the history

  2. refactor(derive): Don't alias arg matches 

    Right now, the aliasing is safe (the compiler says so!) but we're going
to be switching to a `&mut` and need to ensure we don't alias.
    @epage
    epage committed May 18, 2022
    Copy the full SHA
    5806e16 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2022

  1. refactor(derive): Separate sub flattening to avoid aliasing

    @epage
    epage committed May 20, 2022
    Copy the full SHA
    b817c2d View commit details
    Browse the repository at this point in the history

  2. refactor(derive): Consistently handle sub matches

    @epage
    epage committed May 20, 2022
    Copy the full SHA
    18f2950 View commit details
    Browse the repository at this point in the history

  3. refactor(derive): Deconstruct arg matches into enums

    @epage
    epage committed May 20, 2022
    Copy the full SHA
    d61552a View commit details
    Browse the repository at this point in the history

  4. perf(derive): Reuse allocations for external subcommands 

    In case the `ArgMatches` is cloned, this forces a constraint that the
underlying type impls `Clone` but that should be safe as we only support
`String` and `OsString`.
    @epage
    epage committed May 20, 2022
    Copy the full SHA
    0628d04 View commit details
    Browse the repository at this point in the history

  5. feat(derive): Allow users to opt-in to ValueParser 

    For clap 3, its opt-in as a precaution against breaking
compatibility in some weird cases.

This does require the types to implement `Clone`.

Fixes clap-rs#3734
Fixes clap-rs#3496
Fixes clap-rs#3589
    @epage
    epage committed May 20, 2022
    Copy the full SHA
    b52c7f1 View commit details
    Browse the repository at this point in the history

  6. perf(derive): Reuse allocations where possible 

    Only bothered to implement this for `value_parser` cases as `parse`
cases are going to be considered deprecated.
    @epage
    epage committed May 20, 2022
    Copy the full SHA
    7845e60 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2022

  1. feat(derive): Opt-in to inferred value_parser

    @epage
    epage committed May 21, 2022
    Copy the full SHA
    a35df14 View commit details
    Browse the repository at this point in the history

  2. refactor(derive): Separate concerns when removing

    @epage
    epage committed May 21, 2022
    Copy the full SHA
    2fba615 View commit details
    Browse the repository at this point in the history

  3. fix(parser): Print proper upper range bound

    @epage
    epage committed May 21, 2022
    Copy the full SHA
    5b4ea8e View commit details
    Browse the repository at this point in the history

  4. fix(help): Show value_parser's PossibleValues

    @epage
    epage committed May 21, 2022
    Copy the full SHA
    852a1b1 View commit details
    Browse the repository at this point in the history

  5. doc(derive): Update for value_parser

    @epage
    epage committed May 21, 2022
    Copy the full SHA
    e23800e View commit details
    Browse the repository at this point in the history