Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(error): Don't duplicate args in usage #3689

Merged
merged 3 commits into from May 6, 2022
Merged

Commits on May 4, 2022

  1. fix(error): Don't duplicate args in usage

    Gave up trying to decipher the existing logic for safe ways to
    de-duplicate manually and switched to an `IndexSet` to enforce only one
    of each argument exists.
    
    Fixes clap-rs#3556
    epage committed May 4, 2022
    Copy the full SHA
    dedbabd View commit details
    Browse the repository at this point in the history

Commits on May 5, 2022

  1. fix(help): Don't show hidden arguments for conflicts

    This makes it consistent with other errors where we show arguments to
    the user.
    epage committed May 5, 2022
    Copy the full SHA
    f7c2dea View commit details
    Browse the repository at this point in the history
  2. refactor(help): Remove redundant required check

    With us moving the required de-duplication up a level, it made this
    check redundant.  By removing this check, we're more likely to have an
    item in the `incls` which forces a smart usage and reduces the chance of
    an `[ARGS]` or `[OPTIONS]`, so a couple of tests changed.
    epage committed May 5, 2022
    Copy the full SHA
    e23c786 View commit details
    Browse the repository at this point in the history