Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(derive): Couple derive version to clap #3636

Merged
merged 1 commit into from Apr 15, 2022
Merged

Commits on Apr 15, 2022

  1. fix(derive): Couple derive version to clap

    While `clap` depends on `clap_derive`, `clap_derive` inherently has a
    dependency on `clap` because it generates code assuming at least a
    specific clap version.  If a new `clap_derive` is used with an old
    `clap`, it'll generate code that won't compile.
    
    We've kept things loose because of
    - Bad experiences with overly constrained version reqs
    - To not force new `clap` versions to release `clap_derive`.
    - People should have a lock file anyways
    
    The downsides:
    - `cargo install` does not use `Cargo.lock` by default, required
      `--locked`
    - If we want people to not skip non-patch releases when upgrading, we
      need it to not be a pain
    epage committed Apr 15, 2022
    Copy the full SHA
    ed57342 View commit details
    Browse the repository at this point in the history