Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update app_from_crate for App rename #3474

Merged
merged 2 commits into from Feb 15, 2022
Merged

fix: Update app_from_crate for App rename #3474

merged 2 commits into from Feb 15, 2022

Commits on Feb 15, 2022

  1. fix: Update app_from_crate for App rename 

    Instead of just renaming it, I reconsidered what the API should look
like.  A custom separator for author does not make sense positionally
but accepting a name, and defaulting it, does fit with what someone
would expect.

I removed the `_from_crate` suffix because it doesn't seem necessary.
We don't have this kind of naming for the derive.  I feel it cleans
things up this way.
    @epage
    epage committed Feb 15, 2022
    Copy the full SHA
    65b9c88 View commit details
    Browse the repository at this point in the history

  2. docs: Update to new command! macro

    @epage
    epage committed Feb 15, 2022
    Copy the full SHA
    360c4d6 View commit details
    Browse the repository at this point in the history