Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Deprecate most AppSettings #3449

Merged
merged 4 commits into from Feb 11, 2022
Merged

fix: Deprecate most AppSettings #3449

merged 4 commits into from Feb 11, 2022

Commits on Feb 11, 2022

  1. docs: Clarify app-wide vs command-specific settings

    @epage
    epage committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    bdb034b View commit details
    Browse the repository at this point in the history

  2. fix(color): Allow overriding previous settings

    @epage
    epage committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    547665d View commit details
    Browse the repository at this point in the history

  3. fix(error): Deprecate WaitOnError 

    Fixes clap-rs#3439
    @epage
    epage committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    de7c81e View commit details
    Browse the repository at this point in the history

  4. feat: Replace core set of AppSettings with functions 

    This is a part of clap-rs#2717

Some settings didn't get getters because
- They are transient parse settings (e.g. ignore errors)
- They get propagated to args and should be checked there

`is_allow_hyphen_values_set` is a curious case.  In some cases, we only
check the app and not an arg.  This seems suspicious.
    @epage
    epage committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    272f840 View commit details
    Browse the repository at this point in the history