fix(help): ArgsRequiredElseHelp should ignore defaults #3421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samvrlewis
added a commit
to swift-nav/swift-toolbox
that referenced
this pull request
Feb 16, 2022
This gets clap-rs/clap#3421 which enables the help to show when no arguments are given and there are defaults.
samvrlewis
added a commit
to swift-nav/swift-toolbox
that referenced
this pull request
Feb 16, 2022
* Improve error for empty remote path * Fix up serial in usage & some help strings * Add info to file errors * Add error for reading non-existent file * Improve usage and error messages * PATH -> FILE_PATH for delete * Fixed missed PATH -> FILE_PATH * Make error on 0 byte file read more informative This could either mean the file actually is 0 bytes, the file doesn't exist, or the file isn't allowed to be accessed * Update usage Changed "Piksi" to "Swift device" and separated to the "cp to" and "cp from" examples * Use master version of Clap This gets clap-rs/clap#3421 which enables the help to show when no arguments are given and there are defaults. * Fix formatting of cargo.toml * Upgrade to Clap 3.1.0 Co-authored-by: Jason Mobarak <jason@swiftnav.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1264