Requires and Conflicts should ignore default_value #3420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was split out of clap-rs#3020
Unrolling serves two distinct purposes but we muddied them together - Is `requires` satisfied for validation - Report what arguments are currently considered required for usage This was split out of clap-rs#3020
…ault values"""" This reverts commit 26bbe60.
|
Ah, my bad. I missed the previous notification. I was under the impression that old PR has already been merged. |
2 tasks
epage
added a commit
to epage/clap
that referenced
this pull request
Jun 6, 2022
This is a follow up to clap-rs#3420. Its easy to overlook this because it is only useful for the conditionals (we actually prevent applying unconditional defaults to unconditional requireds). This became apparent with the increased use of defaults with `SetTrue`. As always, there is the question of when is a bug fix a breaking change. I'm going to consider this safe since we prevent some instances of this from even happening and we already did clap-rs#3420 and this is in line with those.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #3020
Fixes #3076