Deprecate Setting FromStr along with YAML #3111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These exist pretty much just for YAML (clap-rs#3087). If anyone else is building on these, it has a limited shelf-life anyways because of clap-rs#2717. BREAKING CHANGE: `FromStr` for settings requires the `yaml` feature.
|
Oh nvm. Yeah. We don't want |
pksunkara
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the deserialization logic on top of the builder that #3087 is targeted at.
This does involve a breaking change during the RC period (moving FromStr to the yaml feature) but it seems like a small enough case to be acceptable.