Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(derive)!: Don't Panic, Error #2943

Merged
merged 5 commits into from Oct 26, 2021
Merged

fix(derive)!: Don't Panic, Error #2943

merged 5 commits into from Oct 26, 2021

Commits on Oct 26, 2021

  1. refactor(error): Delay formatting until the end 

    This gives us room to add extra context later.
    @epage
    epage committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    f1bf9fc View commit details
    Browse the repository at this point in the history

  2. refactor(error): Extract formatting of raw messages

    @epage
    epage committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    83b074a View commit details
    Browse the repository at this point in the history

  3. feat(error): Allow separate raise, format sites 

    While `App::error` is what most people will need, `clap_derive` needs to
handle when the site raising the error doesn't have access to the `App`
and needs to defer that to later.
    @epage
    epage committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    3c4340c View commit details
    Browse the repository at this point in the history

  4. fix(error): Never show unrequested color 

    If the user prints a raw error, it may include color even if the user
turned it off at runtime.  Now we'll be more conservative and never show
color for raw errors.
    @epage
    epage committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    f8bca3a View commit details
    Browse the repository at this point in the history

  5. fix(derive)!: Error, don't panic! 

    The derive is generating `Error::raw` (from scratch or by converting
existing erors) and then the inherent `Parser` methods format them.

Fixes clap-rs#2255
    @epage
    epage committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    53e10b4 View commit details
    Browse the repository at this point in the history