Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Rename ArgValue to PossibleValue #2908

Merged
merged 1 commit into from Oct 19, 2021
Merged

fix!: Rename ArgValue to PossibleValue #2908

merged 1 commit into from Oct 19, 2021

Commits on Oct 19, 2021

  1. fix!: Rename ArgValue to PossibleValue

    In considering potential work for clap-rs#2683, I realized we might need a type to carry data for
    each of the `multiple_values`.  `ArgValue` works both for that and for
    possible values, so we need to come up with a better name for one or
    both.  Changing `ArgValue`s name now would be ideal since its new in
    clap3 and by renaming it, we can reduce churn for users.
    
    While thinking about this, I realized I regularly get these mixed
    up, so renaming `ArgValue` to `PossibleValue` I think will help clear
    things up, regardless of clap-rs#2683.
    epage committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    9f12bfe View commit details
    Browse the repository at this point in the history