fix: Deprecate Macro API #2848
Merged
fix: Deprecate Macro API #2848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pksunkara
reviewed
Oct 11, 2021
| @@ -295,6 +295,10 @@ macro_rules! app_from_crate { | |||
| /// [`Arg::max_values(max)`]: crate::Arg::max_values() | |||
| /// [`Arg::validator`]: crate::Arg::validator() | |||
| /// [`Arg::conflicts_with`]: crate::Arg::conflicts_with() | |||
| #[deprecated( | |||
| since = "3.0.0", | |||
| note = "Replaced with `App` builder API (with `From::from` for parsing usage) or `Parser` derive API (Issue #2835)" | |||
There was a problem hiding this comment.
Why do we need (with `From::from` for parsing usage)?
There was a problem hiding this comment.
Since the macro is a compile-time version of the usage parser, I figured people would appreciate knowing where to go for the runtime version.
There was a problem hiding this comment.
It could be phrased better. It felt confusing at first.
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2835