feat: Add backtraces to errors #2827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbknapp
reviewed
Oct 6, 2021
This is gated behind the `debug` feature flag so only explicit debugging cases pay the build time and runtime costs. The builder API's stack traces are generally not too interesting. Where this really helps is with `clap_derive`. We currently panic on unexpected conditions which at least gives us a backtrace. We'd like to turn these into errors but to do so would lose those debuggin backtraces, which is where this comes in. This is a part of clap-rs#2255
ldm0
reviewed
Oct 7, 2021
|
Since the raised concerns are only with implementation details and not the high level idea / design / user-facing aspect, I'm going ahead and merging this and resolving any further issues post-merge. bors r+ |
epage
added
C: alias
M-unreviewed
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Required status check \"CI-PR\" is expected.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is gated behind the
debugfeature flag so only explicit debuggingcases pay the build time and runtime costs.
The builder API's stack traces are generally not too interesting. Where
this really helps is with
clap_derive. We currently panic onunexpected conditions which at least gives us a backtrace. We'd like to
turn these into errors but to do so would lose those debuggin
backtraces, which is where this comes in.
This is a part of #2255