Add support for Multicall executables as subcommands with a Multicall setting #2817
Conversation
This could always be added in the future as an App method for people to set the prefix. I say future because this is an incremental improvement on top of what you have and wouldn't want to see the existing work be blocked on it. |
|
Pushed an update for everything discussed except for checking against name instead of searching for applets, which I'll have to look at tomorrow. |
clap_derive/examples/multicall.rs
Outdated
|
|
||
| fn main() { | ||
| let args = Args::parse(); | ||
| if let Some(path) = args.install { |
There was a problem hiding this comment.
I'm open to opinions here, but I would take out all of the --install logic for the examples as it gets in the way of demo'ing this feature. I would instead just put a comment at the top of the example either quickly explaining what Multicall is and how to set it up manually (i.e. just some links), or give a URL to a blog/article explaining the subject.
Also, the choice of using true and false might also get in the way since many shells will use a builtin, and it requires checking exit codes to verify which isn't explicitly explained. Just using foo / bar and printing those words I think will demo this just fine.
There was a problem hiding this comment.
I can't think of a more well-known example of a multicall binary than busybox, and --install is a feature of it that I think is useful to demonstrate how it would work, even if you'd typically see the links installed via the package manager.
But I can limit that to one example, and doing the hostname example as the clap_derive example will solve a bunch of problems.
There was a problem hiding this comment.
This particular example no longer exists, though the non-derive equivalent has an --install option.
It's a lot less noise since it's unimplemented.
true and false were implemented as they're trivial, but if you think commands which aren't available as builtins would be more useful, cat, cp and rm might be relevant even if unimplemented.
If the AppSettings::Multicall setting is given then argv0 is parsed as the first subcommand argument or parsed as normal with any other name.
…o.toml tests/examples.rs:examples_are_functional finds examples by stripping `.rs` off the basename
|
Build succeeded: |
|
I was expecting an autosquash to happen before merge, sorry about the noisy commits. |
If the AppSettings::Multicall setting is given
then argv0 is parsed as the first subcommand argument
or parsed as normal with any other name.
This handles the feature from the linked issue of
hostname-like behaviour where applets shouldn't be callable from the main command, by having a subcommand with the same name as the main command i.e.hostnamehas ahostnamesubcommand and being called with the executable namehostnameruns thehostnamesubcommand name and runs thednsdomainnamesubcommand if linked asdnsdomainnameThis doesn't handle the busybox feature of nicely reporting that an applet isn't found when a subcommand doesn't match.
This doesn't handle the uutils/coreutils feature of matching names with an optional prefix.
The known unhandled features were left unimplemented for lack of a good idea how to implement and they could be added as additional flags.
Closes #1120