Produce an error for "compact" arguments where takes_value is false #2646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I accidentally introduced this in #2642
|
If I'm reading this correctly, this looks like it solves the same problem as #2619 (just didn't have the Issue associated with it). Are they the same? What are your thoughts on the trade offs between the two approaches? |
ldm0
requested changes
Jul 30, 2021
| @@ -1076,6 +1077,13 @@ impl<'help, 'app> Parser<'help, 'app> { | |||
| self.seen.push(opt.id.clone()); | |||
| if opt.is_set(ArgSettings::TakesValue) { | |||
| return self.parse_opt(&val, opt, matcher); | |||
| } else if let Some(val) = val { | |||
| return Err(ClapError::unknown_argument( | |||
There was a problem hiding this comment.
Could you use ClapError::too_many_values here?
|
I didn't see #2619 before making this, but it seems more thorough than this. Using the too many values error might make more sense to users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1543
The error message produced is: "error: Found argument '=false' which wasn't expected, or isn't valid in this context". This uses
ClapError::unknown_argument.It might be better to remove the "=". If this would be better, I think it would also make sense to not produce the error when "--flag=" is used.