Avoid panicking on invalid UTF-8 in DYM args #1483
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kornelski
changed the title
|
fyi, the v2 branch has been frozen. can you migrate this PR to the v3-master branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo --help`printf "\\x8d00"`panics, because "did you mean?" tries to use the arg with an invalid codepoint. It's an invalid user input, not a programmer bug, so IMHO it shouldn't cause a panic.
This fix uses
to_string_lossy, so this case displays as:Since that's an error case, the lossiness shouldn't be an issue, and the correction is still useful.
Related to #751