Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature: 'iter_matches' #1240

Closed
wants to merge 11 commits into from
Closed

New feature: 'iter_matches' #1240

wants to merge 11 commits into from

Conversation

neysofu
Copy link

@neysofu neysofu commented Apr 1, 2018

Relates to #1206.

I've added support for iterating over ArgMatches in an ordered manner. This feature ships with a new opt-in dependency, indexmap.

It is still a WIP, more specifically I need to:

  • add a new method to ArgMatches to hide implementation details over ArgMatches.args;
  • write its docs; and
  • add some tests (forgive me, for I have sinned).

This change is Reviewable

@mention-bot
Copy link

@neysofu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kbknapp to be a potential reviewer.

@kbknapp
Copy link
Member

kbknapp commented Apr 1, 2018

Looks like a great start! 👍

You could probably also use src/map.rs as a guide since it's doing something very similar with VecMap instead of IndexMap.

@XX
Copy link

XX commented Apr 20, 2018

@neysofu @kbknapp Are the changes still pending? Is there something I can do to help?

@neysofu
Copy link
Author

neysofu commented Apr 21, 2018

@XX I've had some other things to do, but I promise I'll get back to it. I would say ETA is 1 week or less.

@XX
Copy link

XX commented Jul 7, 2018

How about completing this PR?

@Dylan-DPC-zz
Copy link

Thanks for the PR. I'm closing this since it was inactive and clap is on track for a new major release. If you are interested in this, or anyone else wants to pick it up, you can send a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants