fix: Deprecate features redundant with Actions #3797
Merged
+18,488
−865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dropping these will help simplify a lot, including removing of occurrences. These come at the cost of the derive not yet supporting types that impl `From`.
This shouldn't be needed anymore now that this is effectively the new behavior for the non-deprecated actions. This was briefly talked about in clap-rs#2627 but I wasn't familiar enough with the implementation to know how safe it is. Now, maintainrs and users can be more confident because they are explicitly opting into it. See also clap-rs#3795
This mostly exist for - Knowing of the value came from the command-line but we now have `ArgMatches::source` - Counting the number of flags but we now have `ArgAction::Count`
This is needed for deprecate `multiple_occurrences`
For programs opting into the clap v4 behavior (with `action` or `value_parser` attributes), we'll no longer generate a `multiple_occurrences(true)` call in preparation for deprecating `multiple_occurrences`. See clap-rs#3772.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes
ArgAction::StoreValueforArgAction::SetandArgAction::AppendArgAction::IncOccurrencesforArgAction::SetTrueandArgAction::CountArgn::max_occurrencesforvalue_parser!(u64).range(..N)forArgAction::CountCommand::args_override_selfin favor ofArgAction::SetArgMatches::occurrences_ofin favor ofArgAction::CountandArgMatches::value_sourceArg::multiple_occurrencesin favor ofArg::multiple_values(positional),ArgAction::Append(flag with value), orArgAction::Count(flag without value)To help make this a reality
ValueParserfor replacingArg::max_occurrencesmultiple_occurrenceswith new actions (for non-positional)multiple_occurrences