fix: Update app_from_crate for App rename #3474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of just renaming it, I reconsidered what the API should look like. A custom separator for author does not make sense positionally but accepting a name, and defaulting it, does fit with what someone would expect. I removed the `_from_crate` suffix because it doesn't seem necessary. We don't have this kind of naming for the derive. I feel it cleans things up this way.
epage
force-pushed
the
app_from_crate
branch
2 times, most recently
from
4eb269e
to
360c4d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #3472 and is part of resolving #3089.
Instead of just renaming it, I reconsidered what the API should look
like. A custom separator for author does not make sense positionally
but accepting a name, and defaulting it, does fit with what someone
would expect.
I removed the
_from_cratesuffix because it doesn't seem necessary.We don't have this kind of naming for the derive. I feel it cleans
things up this way.