feat(builder): Infer takes_vaue from action

clap-rs · Jun 1, 2022 · e53dd93 · e53dd93
1 parent 91480de
commit e53dd93
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/builder/action.rs b/src/builder/action.rs
@@ -35,7 +35,6 @@ pub enum ArgAction {
     ///     .arg(
     ///         Arg::new("flag")
     ///             .long("flag")
-    ///             .takes_value(true)
     ///             .action(clap::builder::ArgAction::StoreValue)
     ///     );
     ///

diff --git a/src/builder/arg.rs b/src/builder/arg.rs
@@ -1014,7 +1014,6 @@ impl<'help> Arg<'help> {
     ///     .arg(
     ///         Arg::new("flag")
     ///             .long("flag")
-    ///             .takes_value(true)
     ///             .action(clap::builder::ArgAction::StoreValue)
     ///     );
     ///
@@ -4892,6 +4891,13 @@ impl<'help> Arg<'help> {
         if self.is_positional() {
             self.settings.set(ArgSettings::TakesValue);
         }
+        if let Some(action) = self.action.as_ref() {
+            if action.takes_value() {
+                self.settings.set(ArgSettings::TakesValue);
+            } else {
+                self.settings.unset(ArgSettings::TakesValue);
+            }
+        }
 
         if self.value_parser.is_none() {
             if self.is_allow_invalid_utf8_set() {