Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracing support parity with log #44

Closed
wants to merge 1 commit into from
Closed

Add tracing support parity with log #44

wants to merge 1 commit into from

Conversation

ShayBox
Copy link

@ShayBox ShayBox commented Oct 11, 2022

No description provided.

@epage
Copy link
Member

epage commented Oct 11, 2022

This was previously discussed in #37 with #39 being merged.

If we are to discuss this further, I would prefer we do so in an issue before moving to a PR. If nothing else, it keeps the discussion in one place (seeing as we already have 3 PRs related to this topic)

@epage epage closed this Oct 11, 2022
@ShayBox
Copy link
Author

ShayBox commented Oct 11, 2022

Ah I didn't see those issues as they were closed, and It seemed redundant to open an issue to discuss then open a pull request when they're tracked the same as issues.
It also seems redundant to now open an issue to further split the discussion into more pages.

I don't know what the state of tracing / tracing-subscriber was then, but now it appears to be growing in usage and being part of tokio, has good support.
The only reason I see to not merge this is an additional dependency, which can be resolved making log and tracing feature flags, and log enabled by default to keep it from being a breaking change.

@epage
Copy link
Member

epage commented Oct 11, 2022

Please move this conversation to an issue. PRs come and go more often than issues, so they provide a more stable place to hold a conversation. It will also be more discoverable than a rejected PR.

@ShayBox
Copy link
Author

ShayBox commented Oct 11, 2022

You're the only one with the power to move these comments into a separate issue
GitHub Issues and Pull requests are exactly the same, the page url is incremental to both, they're both search indexed on both pages, and they're both as-discoverable as each other, even more so now that they've been referenced from this one.

Anyway, I've said all I needed and submitted my contribution for the discussion, if someone else comes to continue the discussion they can open a new issue
Should this ultimately not be resolved I'll continue to keep my fork synced to upstream, the pull request was more of a last minute action as I didn't search for existing issues, my goal was to create the fork for my own use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants