Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom read zero outside image #301

Open
wants to merge 7 commits into
base: morph_snake_smoothing
Choose a base branch
from

Conversation

haesleinhuepf
Copy link
Member

@haesleinhuepf haesleinhuepf commented Apr 23, 2023

Hey @grahamross123 ,

I eventually managed to look into #296 . Big thanks for working on this!

In this PR to your branch I add a custom read-function based on the original in the preamble. It returns 0 if the coordinates are outside the image.

I'm also adding some tests demonstrating that it now works like in skimage also on image borders.

I created an issue because the read-zero-outside thingy should be supported by the preamble, but is commented out. See #302

Let me know what you think! And thanks again!

Best,
Robert

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07 🎉

Comparison is base (e972ab0) 92.95% compared to head (8c00111) 93.02%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@                    Coverage Diff                    @@
##           morph_snake_smoothing     #301      +/-   ##
=========================================================
+ Coverage                  92.95%   93.02%   +0.07%     
=========================================================
  Files                        773      776       +3     
  Lines                      14237    14340     +103     
=========================================================
+ Hits                       13234    13340     +106     
+ Misses                      1003     1000       -3     
Impacted Files Coverage Δ
pyclesperanto_prototype/_tier1/__init__.py 100.00% <100.00%> (ø)
...clesperanto_prototype/_tier1/_inferior_superior.py 100.00% <100.00%> (ø)
...clesperanto_prototype/_tier1/_superior_inferior.py 100.00% <100.00%> (+37.50%) ⬆️
tests/test_inferior_superior.py 100.00% <100.00%> (ø)
tests/test_superior_inferior.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants