Merge pull request #272 from clEsperanto/fix-histogram-bug-uint8

fix uint8 type in histogram
clEsperanto · Mar 29, 2024 · 6091872 · 6091872
2 parents bc11103 + 9dd0743
commit 6091872
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/clic/src/tier3.cpp b/clic/src/tier3.cpp
@@ -212,10 +212,10 @@ histogram_func(const Device::Pointer & device,
                float                   min,
                float                   max) -> Array::Pointer
 {
-  tier0::create_vector(src, dst, nbins);
+  tier0::create_vector(src, dst, nbins, dType::UINT64);
   size_t number_of_partial_histograms = src->height();
   auto   partial_hist =
-    Array::create(nbins, 1, number_of_partial_histograms, 3, dType::UINT32, src->mtype(), src->device());
+    Array::create(nbins, 1, number_of_partial_histograms, 3, dType::UINT64, src->mtype(), src->device());
   if (std::isnan(max) || std::isnan(max))
   {
     min = tier2::minimum_of_all_pixels_func(device, src);

diff --git a/tests/tier3/test_histogram.cpp b/tests/tier3/test_histogram.cpp
@@ -8,7 +8,7 @@ class TestHistogram : public ::testing::TestWithParam<std::string>
 protected:
   std::array<float, 10 * 5 * 3> input;
   std::array<float, 10>         valid;
-  std::array<float, 10>         output;
+  std::array<uint64_t, 10>      output;
 
   virtual void
   SetUp()