Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed warning about CRA@2 #1481

Merged
merged 2 commits into from
Jan 25, 2019
Merged

Removed warning about CRA@2 #1481

merged 2 commits into from
Jan 25, 2019

Conversation

pomek
Copy link
Member

@pomek pomek commented Jan 23, 2019

Suggested merge commit message (convention)

Docs: Removed warning about CRA@2. See ckeditor/ckeditor5-react#40 (comment).

@pomek pomek requested a review from Reinmar January 23, 2019 14:59
@Reinmar Reinmar requested review from ma2ciek and removed request for Reinmar January 23, 2019 18:30
Copy link
Contributor

@ma2ciek ma2ciek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Later in the docs, there's still usage of the create-react-app@1 - https://github.com/ckeditor/ckeditor5/pull/1481/files#diff-bde8adc481cd75550e7606d2117fd48eR153. And I'd use there only yarn to install packages since the whole initial installation is done by yarn by default (or this is because I have yarn globally installed (?)).

Is it possible to run react app without ejecting config now?

@ma2ciek
Copy link
Contributor

ma2ciek commented Jan 24, 2019

Without ejecting the SVGs are broken with our beloved error:

TypeError: Cannot read property 'getAttribute' of null
at IconView._updateXMLContent (iconview.js:121)
    at IconView.render (iconview.js:94)
	...

@pomek
Copy link
Member Author

pomek commented Jan 25, 2019

Is it possible to run react app without ejecting config now?

That's the goal of changing our sources…

Without ejecting the SVGs are broken with our beloved error:

The later in the same documentation:

The configuration needs to be ejected in order to be able to customize webpack configuration. To build CKEditor 5 from source you must load inline SVG images and handle CKEditor 5's CSS as well as correctly minify the ES6 source.

You can use ready-to-use builds without ejecting.

@pomek
Copy link
Member Author

pomek commented Jan 25, 2019

But if you would use CKEditor 5 Framework, you must eject the configuration.

@pomek
Copy link
Member Author

pomek commented Jan 25, 2019

Or create a new build and attach it to the React Component. Both ways are described in the documentation.

@ma2ciek ma2ciek merged commit fa9af9d into master Jan 25, 2019
@ma2ciek ma2ciek deleted the t/ckeditor5-react/40 branch January 25, 2019 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants