Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Replaced for..of with Array.prototype.forEach #271

Merged
merged 1 commit into from
Jan 25, 2019
Merged

Conversation

pomek
Copy link
Member

@pomek pomek commented Jan 23, 2019

Suggested merge commit message (convention)

Other: Replaced for..of statement in EventEmitter with Array.prototype.forEach. This changes allows building a React application using create-react-app@2. Closes ckeditor/ckeditor5-react#40.

@pomek pomek requested a review from Reinmar January 23, 2019 14:57
@Reinmar Reinmar requested review from ma2ciek and removed request for Reinmar January 23, 2019 18:30
@ma2ciek
Copy link
Contributor

ma2ciek commented Jan 25, 2019

I've checked it and it indeed fixes the mentioned problem.

@ma2ciek ma2ciek merged commit 900b54b into master Jan 25, 2019
@ma2ciek ma2ciek deleted the t/ckeditor5-react/40 branch January 25, 2019 14:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants