Update Package Generator for NIM. #166
Conversation
…thods of installations.
…o-legacy-templates Fix (generator): Allow to build plugin with potentially used external `ckeditor5-premium-features`. Closes #000.
There was a problem hiding this comment.
The build:dist script in non-legacy TS package using yarn shows some kind of warning:
$ yarn run build:dist
yarn run v1.22.19
$ node ./scripts/build-dist.mjs
1/2: Generating NPM build...
2/2: Generating browser build...
No name was provided for external module "ckeditor5" in "output.globals" – guessing "ckeditor5".
Done in 5.36s.
Other than that, everything seems to work properly.
| @@ -0,0 +1,16 @@ | |||
| /** | |||
There was a problem hiding this comment.
This is JSON file, not JSON with comments. Should this comment be here? Perhaps we could change the format? That might require some additional packages though. Consider moving such comments to README.md.
There was a problem hiding this comment.
Will remove it from here and will mention about it in docs for package-generator and in migration guide.
| @@ -68,7 +71,7 @@ function copyTemplate( templatePath, packagePath, data ) { | |||
|
|
|||
| const processedTemplatePath = templatePath | |||
| // Remove sub-directory inside templates to merge results into one directory. | |||
| .replace( /^(?:common|js|ts)(?:\\|\/)/, '' ) | |||
| .replace( /^(?:common|js|ts|legacy-js|legacy-ts)(?:\\|\/)/, '' ) | |||
There was a problem hiding this comment.
I am really sorry for such nitpicks, but could we change legacy-js/legacy-ts to js-legacy/ts-legacy? It would look nicer in the directory tree
There was a problem hiding this comment.
Fully agree. Addressed in 9b05427
Co-authored-by: przemyslaw-zan <69513154+przemyslaw-zan@users.noreply.github.com>
Yes, it's on out todo list to fix in |
…o keys: 'module' and 'exports'.
…--without-legacy-methods' will be generate package with only NIM support.
|
@przemyslaw-zan we decided to name the flag |
|
Changes from this branch have been released: https://github.com/ckeditor/ckeditor5-package-generator/releases/tag/v2.0.0-alpha.0. |
Suggested merge commit message (convention)
Feature (generator): New flag
--use-only-new-installation-methodsthat should allow to generate package without support for DLLs. See ckeditor/ckeditor5#15502, ckeditor/ckeditor5#15739ℹ️ After approved review we would like to release alpha version - to make it available for tests. ℹ️
Additional information
ckeditor5andckeditor5-premium-featuresare usingnightly,Supported scopes
generator→ https://www.npmjs.com/package/ckeditor5-package-generator*→ https://www.npmjs.com/package/@ckeditor/ckeditor5-package-*