-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added config option that allows to preserve zero margins #2952
Conversation
Rebased on latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rename config to keepZeroMargins
since keepEmptyMarigns
is not precise enough and empty
may be interpreted in many ways. Also it will be easier to find when using phrases like zero margin
in our API docs.
Could you also add fixtures for Safari?
Co-Authored-By: engineering-this <k.litwinowicz@cksource.com>
Co-Authored-By: engineering-this <k.litwinowicz@cksource.com>
Co-Authored-By: engineering-this <k.litwinowicz@cksource.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
I'm just missing Safari fixtures (requested in #2952 (review)). Unless, Safari fixtures are identical as Chrome or Firefox one and can be skipped.
I was sure I've added Safari fixtures, apparently I was wrong. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
What is the purpose of this pull request?
New feature
Does your PR contain necessary tests?
All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
What changes did you make?
Updated PFW filter to keep
margin-*:0
style whenconfig.pasteFromWord_keepEmptyMargins=true
.Closes #2935
Important note: there is still ongoing discussion in #2935 until we fully agree if this solution is what we want this shouldn't be reviewed.