Catch TypeError from invalid dates thrown by dateutils #6056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also provide better logs so that it is possible to identify the issue.
kentsanggds
changed the title
|
Just to add a note, this due to a bug in dateutil dateutil/dateutil#1108 |
Zharktas
approved these changes
May 12, 2021
|
@Zharktas this was merged to the @kentsanggds thanks for your patch, all PRs should target master and we then cherry-pick the changes to the release branches |
|
Bah, the one time i didn't check that it was done against master, I'll fix it. |
Zharktas
added a commit
that referenced
this pull request
May 12, 2021
Catch TypeError from invalid dates thrown by dateutils
|
I wonder if we can configure Github in some way to "only accept PRs against master" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Problem with catching TypeErrors thrown when an invalid date like
20/062012and2014-15are passed in as date strings.Proposed fixes:
Catch TypeError and provide an error log so that devs can investigate any issues.
Features:
Please [X] all the boxes above that apply