Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only run tests workflow when needed #1332

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dbatten5
Copy link

@dbatten5 dbatten5 commented Apr 22, 2023

  • ignore files that don't need tests, e.g. files in docs/ and .md files

closes #1328

- ignore files that don't need tests, e.g. files in `docs/` and `.md`
  files
Copy link

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@Ceddicedced Ceddicedced left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever!

@bosd
Copy link

bosd commented Feb 27, 2024

@cjolowicz Can you please have a look at this? and merge 🙏

@webknjaz
Copy link

This will cause problems with branch projection rules since the expected checks will stop showing up for docs-only changes. This can be solved by having a job that determines what other jobs should run. It's done in python/cpython, pypa/pip, ansible/pylibssh to give a few examples of reference implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore the tests github action workflow if not necessary
4 participants