Feat/svg icons 1396 #1524
Merged
Feat/svg icons 1396 #1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsauntson
commented
Sep 29, 2021
engine/app/components/citizens_advice_components/icons/arrow_down.html.erb
Outdated
Show resolved
Hide resolved
davidrapson
reviewed
Sep 29, 2021
There was a problem hiding this comment.
Looking great so far. Only thing I'm a little stuck on is the icon name behaviour. I think I might be missing where that's used.
And had a little question about the composition + inheritance for the base class. Wondering if the base icon class we inherit from is a different concept to the base icon component we render inside each icon.
engine/app/components/citizens_advice_components/icons/arrow_down.html.erb
Outdated
Show resolved
Hide resolved
davidrapson
reviewed
Sep 29, 2021
engine/app/components/citizens_advice_components/targeted_content.html.haml
Outdated
Show resolved
Hide resolved
davidrapson
reviewed
Sep 29, 2021
engine/previews/citizens_advice_components/icons_preview/icons.html.haml
Show resolved
Hide resolved
davidrapson
reviewed
Sep 29, 2021
engine/app/components/citizens_advice_components/targeted_content.html.haml
Outdated
Show resolved
Hide resolved
davidrapson
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds icon svg view components to the design system:
CitizensAdviceComponents::Icons::Base, which renders outer svg and associated props/assets(see below)This PR is already quite noisy so I want to complete the following tasks in separate PRs:
/assets(not used as far as I can tell), add it into the package, test in public-website and update icon docsCitizensAdviceComponents::Button(and anything else?)Partial fix for #1396