Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVG icon system #1396

Open
davidsauntson opened this issue Aug 5, 2021 · 0 comments · Fixed by #1524
Open

SVG icon system #1396

davidsauntson opened this issue Aug 5, 2021 · 0 comments · Fixed by #1524
Assignees
@marianayovcheva
Labels
tech debt Technical tasks that would usually form a contribution
Projects
💫 Bugs & Tech debt

Comments

@davidsauntson
Copy link
Contributor

Switch to using plain SVGs for icons rather than a font https://css-tricks.com/icon-fonts-vs-svg/ Aside from the resilience and performance benefits might help with this too.

Add icons as individual SVGs inside bounding box

Updating icons in existing components
@davidsauntson davidsauntson added the tech debt Technical tasks that would usually form a contribution label Aug 5, 2021
@davidsauntson davidsauntson added this to Needs triage in 💫 Bugs & Tech debt via automation Aug 5, 2021
@davidsauntson davidsauntson moved this from Needs assessment to In progress in 💫 Bugs & Tech debt Aug 26, 2021
@davidsauntson davidsauntson mentioned this issue Sep 29, 2021
Merged
@davidsauntson davidsauntson linked a pull request Sep 29, 2021 that will close this issue
Feat/svg icons 1396 #1524
Merged
@davidsauntson davidsauntson mentioned this issue Oct 5, 2021
Merged
@davidsauntson davidsauntson moved this from In progress to Closed in 💫 Bugs & Tech debt Oct 19, 2021
@marianayovcheva marianayovcheva self-assigned this Feb 11, 2022
@davidrapson davidrapson mentioned this issue Jul 25, 2022
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marianayovcheva marianayovcheva

Labels
tech debt Technical tasks that would usually form a contribution
Projects
💫 Bugs & Tech debt
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/svg icons 1396 citizensadvice/design-system
2 participants
@davidsauntson @marianayovcheva